kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fixes #254 - jalc504 fix open local repo from main page #260

Closed Jess-Alcantara closed 5 years ago

Jess-Alcantara commented 5 years ago

Related Issue/Keyword:

254

Description:

The problem was that clicking Browse and Open a local repository did nothing.

Testing:

Steps for manual testing:

  1. Login to VisualGit
  2. Click the "Open Local" tab
  3. Click "Browse and Open"
  4. Select a local repository from the file browser
  5. The local repository should open

Checklist:

liamtbrand commented 5 years ago

I just tested and can confirm that this fixes the issue. I would like to know what the original line's purpose was before merging this though just to be sure we're not breaking something.

Jess-Alcantara commented 5 years ago

Good call @liamtbrand. I removed the line because updateProjectWindow() is already called in openRepository() which is called at the end of openLocalRepository(). This meant that the function is called twice when opening a local repository. I also figured that calling it twice was not necessary as it is not called twice when opening a local repo from the text field (i.e. not through the file browser picker).