search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] Console error when there is no repo opened #262

Closed joel-clarke closed 5 years ago

joel-clarke commented 5 years ago

Describe the bug Currently when the app is first opened an error is displayed in the console "Error in git.ts. Attempting to display modified files." This error will be constantly printed to console until from what I can see a repo is opened.

To reproduce

  1. Open VisualGit
  2. Open up the console (ctrl + shift + i)
  3. See the error displayed, notice its counter will increase the longer you wait
  4. Open up a repo
  5. The errors counter should no longer increase

Expected behavior / Acceptance criteria The error seems to be caused by the function which checks for any files that have been changed, hence the error should not be displayed when the app is first opened as there is no files that could have been changed when there is no repo open.

Screenshots error_git_ts

Desktop (please complete the following information):

rmberriman commented 5 years ago

Can recreate, it seems unnecessary for the function to be running there is no repo open - approved.

encryptededdy commented 5 years ago

I thought this was fixed but turns out that was fixed the same time the whole file change detection was broken lol.

Anyway, approved

Ravid12 commented 5 years ago

Approved, Can recreate on windows 10!