kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Closes #37 collapsible forks when cloning #264

Closed emipeanz closed 5 years ago

emipeanz commented 5 years ago

Related Issue/Keyword:

Closes #37

Description:

When cloning a repo from the repository list, everything would just be populated in no particular order. This PR puts all forks in a expandable list underneath the parent repository name. Untitled-1

Side Note

After merging changes from master into this branch, the method displayBranch in repo.ts didn't seem to be used anymore, rather the method displayRepo in authenticate.ts was being used to populate the repo list. I tried deleting the displayRepo method entirely and the whole thing seemed to still work. I've left the method in now for arguments sake, but later we might want to get rid of it if its actually useless.

Testing:

Needs to be manually tested

Steps for manual testing:

  1. Open and log into Visual Git
  2. Click repository from up top (ie. go and clone one of your repos)
  3. Observe that forks are listed under the main repository's header and by clicking said header, the list expands to all forks available
  4. Clone a repo to make sure cloning is still all good

Checklist:

Ravid12 commented 5 years ago

🔥 🔥 🔥