kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] Signout broken in local repository #272

Open Z-Qi opened 5 years ago

Z-Qi commented 5 years ago

Describe the bug The current signout seems to have stopped working as intended due to a change in #173, the move from using confirmSignOut() has caused the signout warning to no longer show up. Instead when signout is clicked (where there are modified files) the exit application warning is shown also described in #188.

To reproduce Steps to reproduce the behavior:

Open a local repository with changes
Click on signout
Exit warning is shown instead of the intended signout warning

Expected behavior / Acceptance criteria Functionality is returned to prior, signing out produces signout warnings where appropriate.

Screenshots ajftG4VJ4Z

Desktop (please complete the following information):

OS: Win10, has also been tested on OSX

Related issues

188

lukethompsxn commented 5 years ago

Approved! I can reproduce this issue

Jess-Alcantara commented 5 years ago

Approved 👍

hhagenson28 commented 5 years ago

I had also noticed this, approved!