rmberriman commented 5 years ago

Description In working on Issue #20, I discovered that the pulling doesn't check whether the remote is ahead of commits or not. It would be nice to check if the repository is ahead of the local, and pull if necessary. This functionality is separate from Pulling directly after cloning crashing the app, as that cannot be solved by this change.

Acceptance criteria

When you pull from a repository that has no changes it says that there are no changes to pull
When you pull from a repository with changes, it pulls the changes and says that the repository was successfully pulled from.

Additional context This is the expected behaviour for when the repository has no changes to pull:

Like GitHubDesktop it can fetch changes and see if there is a need to pull:

I was not able to fix pulling directly after cloning the application (it still crashes) and pulling twice in a row still crashes VisualGit as that is just a fun functionality of nodegit and it's love for segmentation faults.

Related issues

20 , #55 (Also read through #228 if you want to know more about nodegit's fun issues)

DionBalmforth commented 5 years ago

This would be a nice feature to have - approved.

aorthi commented 5 years ago

Very useful feature! Approved :)

hhagenson28 commented 5 years ago

Agree, this would be a useful feature - approved!

kblincoe / VisualGit_SE701_2019_1

[FEATURE] Pull Checks for Changes Before Pulling From Remote #274

20 , #55 (Also read through #228 if you want to know more about nodegit's fun issues)