kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

fix display branch method #282

Closed Ravid12 closed 5 years ago

Ravid12 commented 5 years ago

Related Issue/Keyword:

closes #280

Description:

Not quite sure what the old code was doing - spent a bit of time trying to figure out how it worked / what it was trying to do, but it appears there was an error on the old line 410 let parent = name.split('/')[1];. Since in most cases, parent did not contain a '/' character, this method returned null and caused the rest of it to break. I reverted the changes to this method introduced in PR#234, and everything appeared to be working as normal. @emipeanz , just wondering what the purpose of the original code there was?

Testing:

Steps for manual testing:

  1. Open a repo
  2. Graph should display

Checklist:

Ravid12 commented 5 years ago

Please don't merge this unless @emipeanz clarifies what that method did originally and if there is a fix to keep that original functionality 😄 🥂

emipeanz commented 5 years ago

What the display branch method I altered did was it grouped branches by their parent repository, then underneath that listed all the forks. So you could click a repo and it would give you all the forks that you could clone 😬