search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] Can attempt to create branch with empty name #287

Closed joel-clarke closed 5 years ago

joel-clarke commented 5 years ago

Describe the bug If you attempt to create a valid branch the creation button becomes enabled, however if you click out of the area the text field is cleared but the button remains enabled. This bug was introduced in #30 as it changed where the clearing of the branch creation text field took place and the button enabling/disabling.

To reproduce Steps to reproduce the behavior:

  1. Go to the screen where you can view the graph
  2. Enter a valid branch name which enables the creation button
  3. Click anywhere on the application that is unrelated to the branch creation (the branch creation drop down should close)
  4. Re-open the branch drop down
  5. Press the "OK" button with no branch name entered

Expected behavior / Acceptance criteria Branch creation/search button should be disabled when the branch drop down has no characters entered.

Screenshots What it should be disabled What can happen enabled

Desktop:

Related issues

30

bcox280 commented 5 years ago

Approved

rmberriman commented 5 years ago

Approved!

twchen97 commented 5 years ago

Approved