kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fixes #189 - Alerting user when no username or password given #291

Closed aorthi closed 5 years ago

aorthi commented 5 years ago

Related Issue/Keyword:

Closes issue #189

Description:

Previously when a user attempted to press the sign in button without inputting a username or password, nothing would happen. Now, the user is presented with an alert that asks them to provide a username. If the user then types in a username and no password, they are asked to provide the password.

Steps for manual testing:

  1. Open VisualGit to the log in page 1a. If you have previously saved your credentials and are automatically signed in, sign out.
  2. Ensure nothing has been typed into the username or password box and press the 'Sign In' button
  3. Check that you are presented with an alert box with the following message: 'Please enter your username to sign in'
  4. Enter some text into the username box, leaving the password box empty, and press the 'Sign In' button again
  5. Check that you are presented with an alert box with the following message: 'Please enter your password to sign in'
  6. Removed your inputted username, enter some text into the password box, and once again press the 'Sign In' button
  7. Check that you are presented with an alert box with the following message: 'Please enter your username to sign in'
  8. Enter both a username and password, ensuring one is incorrect, and press the 'Sign In' button again.
  9. Check that you are presented with an alert box with the following message: 'Error: Bad credentials'

Checklist:

cat booping nose