The color.ts file located in app/misc/ was previously very messy, containing large amounts of duplicated code and poorly named variables. I have reworked this design by separating each different theme into its own file, using a common interface ITheme. These themes can now be applied directly through the constants in theme.ts, and any new themes can be easily implemented by adding a new theme file.
Testing:
Steps for manual testing:
Login to VisualGit
Using the Style dropdown menu, select a different theme
Ensure that all the themes can be applied to the application without any errors
Note: Some aspects of the UI aren't being themed properly, I suspect this might be due to the fact that these UI elements were added after the themes had been originally created. We should create a new issue to address these theming problems.
Checklist:
[x] Latest master merged/rebased into your feature branch
[x] Tests covering all changes
[x] Meets the projects coding conventions
[x] No out of scope changes
[x] @Mentioned any relevant team members
[x] No failure when running the linter (npm run lint)
Related Issue/Keyword:
Closes #251
Description:
The
color.tsfile located inapp/misc/was previously very messy, containing large amounts of duplicated code and poorly named variables. I have reworked this design by separating each different theme into its own file, using a common interfaceITheme. These themes can now be applied directly through the constants intheme.ts, and any new themes can be easily implemented by adding a new theme file.Testing:
Steps for manual testing:
Styledropdown menu, select a different themeNote: Some aspects of the UI aren't being themed properly, I suspect this might be due to the fact that these UI elements were added after the themes had been originally created. We should create a new issue to address these theming problems.
Checklist:
npm run lint)