kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fix #194 fix slight gap in clone ui #304

Closed nathan-cairns closed 5 years ago

nathan-cairns commented 5 years ago

Related Issue/Keyword:

closes #194 and readdresses #116

Description:

I basically just replaced all the rounded edges with straight edges. This was done to remove the gap on between inputs in the clone UI as described in #194. I also did this to make all our buttons and inputs consistent across the UI related to #116 . i.e. there was a mix of square and rounded inputs so I just unified it to be square. If y'all think it would look nicer rounded I can change everything to be rounded instead.

Let me know :)

Have a good review :):)

Testing:

Steps for manual testing:

  1. Go through the UI and ensure all the input type things are square not rounded

Checklist:

nathan-cairns commented 5 years ago

@joel-clarke Hey dude please review and merge this chur :)

SamuelZheng11 commented 5 years ago

Explain

The dropdown on branch selection when you have a repo selected is rounded but the branch search box is not, I would recommend sticking to one style for both. Otherwise it looks good :D

nathan-cairns commented 5 years ago

sweet as guys ill make these changes. If yall dont mind im gonna stick with square cause rounded is yuck (imo) :).

joel-clarke commented 5 years ago

Hey @Nathan-Cairns, the "Open Recent" repo section still has rounded edges as well as the commit button, were these meant to be fixed for consistency? image image

nathan-cairns commented 5 years ago

Yep sorry Im doing that right now in another commit just had to do some other stuff. Should be done in like 10 mins

nathan-cairns commented 5 years ago

Should be good now @joel-clarke

joel-clarke commented 5 years ago

Looking good, much cleaner and consistent now.