kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fixes #287 Can attempt to create branch with empty name #305

Closed joel-clarke closed 5 years ago

joel-clarke commented 5 years ago

Related Issue/Keyword:

Closes #287

Description:

Previously you were able to create a branch with an empty name after entering a valid branch name, closing the branch drop down and then reopening it. This should now not be possible.

Testing:

Steps for manual testing:

  1. Go to the screen where you can view the graph
  2. Enter a valid branch name which enables the creation button
  3. Click anywhere on the application that is unrelated to the branch creation (the branch creation drop down should close)
  4. Re-open the branch drop down
  5. The "Ok" button should now be disabled
  6. Check you are able to still create branches

Checklist: