fixes #284 fix code base typo

nathan-cairns commented 5 years ago

Related Issue/Keyword:

fixes #284

Description:

So I went to fix this typo as requested in #284 but found the variable was not actually used anywhere in the project so I removed it. There actually appears to be a decent number of unused variables in the project. I think it would be beneficial to remove this unused code and will make an issue for this accordingly.

Testing:

Steps for manual testing:

Double check that the avaterImg variable wasnt actually used anywhere in the project
Check the app functionality was not affected

Checklist:

[x] Latest master merged/rebased into your feature branch
[x] Tests covering all changes
[x] Meets the projects coding conventions
[x] No out of scope changes
[x] @Mentioned any relevant team members
[x] No failure when running the linter (npm run lint) - The linter is failing again, however, not due to my changes. People really need to start running this thing.
[x] Included a relevant gif (search here for inspiration)

SamuelZheng11 commented 5 years ago

Reviewed the branch and file change, all looks good, No functionality change found

nathan-cairns commented 5 years ago

For documentation purposes this PR inspired the creation of #307

nathan-cairns commented 5 years ago

Thanks @SamuelZheng11 merge at your leisure!

SamuelZheng11 commented 5 years ago

Hold did the lint pass?

Edit: it passes lint

kblincoe / VisualGit_SE701_2019_1