search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[IMPROVEMENT] Remove unused variables #307

Closed nathan-cairns closed 5 years ago

nathan-cairns commented 5 years ago

Description There is currently a ton of unused variables in the project. This technical debt should be cleaned up so our code is easier to read and maintain. This has probably come about from making changes to code but not cleaning up afterwards.

For example: The aid and atoken variables in authenticate.ts are never used in the project.

Acceptance criteria

Pointers / Solutions Your IDE should be smart enough to detect when a variable is not used in a file. It might be worth double checking these are not used in other files by using your IDE's project search functionality. (e.g. in vs code CTRL + SHIFT + F).

Related issues This issue came about as a result of #284 and #306

swimuel commented 5 years ago

Approved

oscarcs commented 5 years ago

Approved.

darcycox97 commented 5 years ago

Approved - just a note to be very careful about removing variables that aren't referenced in the code. Many of the files in this project rely on variables in a global scope so many of them appear to not be used but could actually be essential to the functionality