kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fixes #224 - Unused buttons when viewing file changes #311

Closed hhagenson28 closed 5 years ago

hhagenson28 commented 5 years ago

Related Issue/Keyword:

Issue #224 Follow up to PR #283

Description:

Same as #283 - just removed the event listeners for the save and cancel buttons as they were producing TypeErrors due to the buttons having already been removed in the previous PR.

Testing:

Steps for manual testing:

  1. Ensure that the TypeError referenced in #224 is no longer apparent in the console when VisualGit is running.
  2. All other functionality should still work the same as it did before, especially the file editing functionality.

Checklist:

hhagenson28 commented 5 years ago

The commit history of this PR just got really messy, but you can have another look @Buster-Darragh-Major

Buster-Darragh-Major commented 5 years ago

LGTM 👍