kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fixes #147 - Resize line changes panel #316

Closed hhagenson28 closed 5 years ago

hhagenson28 commented 5 years ago

Related Issue/Keyword:

Closes #147

Description:

After a lot of trial and error, I have been able to adjust the dimensions of the line changes panel so that:

In order to achieve this I had to restructure how the repository name and branch name are shown in the header. These are now limited to the top line of the header with ellipsis (...) for the overflow but you can hover over the text to see their full names. This was done to ensure that the sizing of the header, footer and body content remains consistent and nothing is being hidden behind anything else.

Making these changes will make issue #279 easier to achieve as well.

Testing:

Steps for manual testing:

  1. Open up a repo with modified files
  2. View the line changes of a modified file and check that you can see all of the changes for the following:
    • [ ] a one line change
    • [ ] multiple line changes (enough changes that the vertical scroll bar is active)
    • [ ] a change that occurs on a long line (in order to view the horizontal scroll bar)
  3. Ensure that you can see the full repo and branch names by hovering over the text for these

None of the lines in the panel should be hidden behind the command console.

Thank you to @SheepySean for your help with the CSS and providing very helpful solutions!

(Please ignore all of the commits to do with the package-lock file, I don't know what its problem is)

Checklist:

liamtbrand commented 5 years ago

Note to reviewer(s): This is going to conflict with #315. Resolving these conflicts shouldn't be too bad, just have a look at the files changed and the reasons it should be pretty straight forward to resolve. Let me know if you need help.

hhagenson28 commented 5 years ago

@SamuelZheng11 Yes, this issue with the colours being cut off has been noted in issue #204 and therefore, is not related to my changes.

SamuelZheng11 commented 5 years ago

@SamuelZheng11 Yes, this issue with the colours being cut off has been noted in issue #204 and therefore, is not related to my changes.

Ah Ok I approve then

hhagenson28 commented 5 years ago

@SamuelZheng11 the conflicts have now been fixed so you can merge this in too!