search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] The branch search/creation text field does not always clear #324

Open joel-clarke opened 5 years ago

joel-clarke commented 5 years ago

Describe the bug This was caused by a accidental change in PR #316, it removed an input to a function being called when the branch drop down is selected. This caused the the text field to not be cleared in some instances, and when attempting to do so would throw an error to the console.

To reproduce Steps to reproduce the behavior:

  1. Go to the screen where you can view the graph
  2. Enter a branch name
  3. Click anywhere on the application that is unrelated to the branch creation (the branch creation drop down should close)
  4. Re-open the branch drop down
  5. The text field will not be cleared

Expected behavior / Acceptance criteria In step 5 of the testing the text field should be cleared.

Screenshots image

Desktop (please complete the following information):

Related issues PR #316 Related to issue #287

SamuelZheng11 commented 5 years ago

Uh Edit, I am no longer able to replicate, Windows 10