search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Opening a local repository with or without signing in results in filepath not string error #101

Closed Excaleo closed 5 years ago

Excaleo commented 5 years ago

As of the current master build, opening a local repository results in the following error.

Environment: Ubuntu 16.04

Screenshot: image

Steps to reproduce:

  1. Start VisualGit.
  2. Select continue without signing in.
  3. Open any local repository.

Update: The issue was in the repo.ts file where the path variable was redefined within an if statement. However, I get this new issue and will investigate it.

image

Excaleo commented 5 years ago

Might be related to #26

egodihc commented 5 years ago

Some maybe useful information: I could reproduce the bug, but was easily fixed after removing the "const" keyword before the "fullLocalPath" variable on line 76. I didn't get the second error that you did, so maybe you changed the code differently? Although it should be noted that I am using Windows 10.

Excaleo commented 5 years ago

@lincolnChoy I made the same change as you and I'm getting the second bug, might just be in my environment.

rocketBANG commented 5 years ago

yeah, the fix @lincolnChoy suggested works. @Excale0 I've gotten the "Opening Failed - true" when nodegit isn't working properly, I think it is issues with your environment

Excaleo commented 5 years ago

@rocketBANG yea it might be an environment issue since all other exceptions are logged properly. I'll create a PR for the initial issue.

rocketBANG commented 5 years ago

Fixed in #104