search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Add credential service (stores and encrypts log creds) #103

Closed qw closed 5 years ago

qw commented 5 years ago

Resolves #87 , resolves #51

This is based on #100, so probably a good idea to review that one first.

Menake commented 5 years ago

LGTM, once @rocketBANG 's changes are made

Menake commented 5 years ago

@shurui-li, can you squash into one commit and rename branch so merge commit on master identifies added changes.

qw commented 5 years ago

@shurui-li, can you squash into one commit and rename branch so merge commit on master identifies added changes.

For the squashing let's see what happens after #100 is approved as that is the first commit in this PR.

Also did you mean rename commit or rename branch?

Menake commented 5 years ago

@shurui-li, can you squash into one commit and rename branch so merge commit on master identifies added changes.

For the squashing let's see what happens after #100 is approved as that is the first commit in this PR.

Also did you mean rename commit or rename branch?

I meant rename branch, but I guess it's not too important. I was just thinking it would be ideal to have a more meaningful name instead of "shu"

qw commented 5 years ago

Where does it show up in the masters history?

Also I won't change it as I would need to open a new PR for a new branch and lose the reviews. Will look out in the future though.

On Thu, 28 Mar 2019 at 7:49 PM, Menake Ratnayake notifications@github.com wrote:

@shurui-li https://github.com/shurui-li, can you squash into one commit and rename branch so merge commit on master identifies added changes.

For the squashing let's see what happens after #100 https://github.com/kblincoe/VisualGit_SE701_2019_4/pull/100 is approved as that is the first commit in this PR.

Also did you mean rename commit or rename branch?

I meant rename branch, but I guess it's not too important. I was just thinking it would be ideal to have a more meaningful name instead of "shu"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kblincoe/VisualGit_SE701_2019_4/pull/103#issuecomment-477470835, or mute the thread https://github.com/notifications/unsubscribe-auth/AbPSfuLze1Lz4Z9mcs9jyJeaCy1-_YvEks5vbGXdgaJpZM4cPSnc .

qw commented 5 years ago

Great job and thanks for getting on the refactoring train nice and early in the project 💯

Yessss you too wiping out the real logins.