search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Upgrading Angular version #114

Closed egodihc closed 5 years ago

egodihc commented 5 years ago

Related to #88

Currently trying to implement routing for the application. However, the NgModule decorator is needed to create the app module to register the routes and this isn't available in the Angular version we're using. We may need to update our Angular version and maybe the @angular/router version in order to implement routing. It should be noted that this will likely create bugs elsewhere in the application.

Edit: I just tested this while implementing routing and everything still seems to be working.

qw commented 5 years ago

Which Angular are you thinking about? I heard version 4 was the closest to 2 (the one we have now). And which one have you tested it with?

egodihc commented 5 years ago

Which Angular are you thinking about? I heard version 4 was the closest to 2 (the one we have now). And which one have you tested it with?

I've only upgraded from 2.0.0-rc.1 to 2.0.0-rc.5. But for the router version, I've upgraded from 2.0.0-rc.1 to 3.0.0-rc.1 (this shouldn't really affect anything as we weren't using angular router anyways).

qw commented 5 years ago

Ah ok, that sounds good, since there is no change in major Angular version.