kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Theming bug with routing implemented #116

Closed egodihc closed 5 years ago

egodihc commented 5 years ago

Related to #88

While implementing routing, I found that the color themes do not persist after choosing one and moving onto a new route. This is due to the way that the old routing system was implemented. All of the components were stacked on top of each other and "routing" was done through changing the z-index's of the relevant components.

A better way to implement theming could involve using a service and checking the theme through the service to apply the theme color for the HTML elements via ngClass or ngStyle.

Note: This feature is not blocked by the routing issue.

HenrygShen commented 5 years ago

Related to #4