Upgrade electron and nodegit versions to fix Ubuntu characters

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Upgrade electron and nodegit versions to fix Ubuntu characters #124

Closed rocketBANG closed 5 years ago

rocketBANG commented 5 years ago

closes #108

rocketBANG commented 5 years ago

are u sure nothing is dependent on the specific versions of nodegit and electron that we were using?

Yep as far as I can tell there isn't. I didn't get any warning about peer dependencies regarding them when I ran install and VisualGit worked as expected when I ran it.
It's only a incremental upgrade for electron so not much should change from it

qhen143 commented 5 years ago

Tested on WIndows 10. Friendly reminder to update .npmrc to '1.8.8' from '1.2.8' when re-installing packages.