Can now save theme - Githubissues

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Can now save theme #132

Closed HenrygShen closed 5 years ago

HenrygShen commented 5 years ago

Closes #4. Themes were previously not persistent across sessions. Now the theme is saved to a file named appSettings.json. appSettings is used to save data across sessions, and we could possibly merge creds.json into this. @shurui-li Let me know if this is a good idea.

qw commented 5 years ago

At least for now don't merge creds.services.ts into this as they are two separate things, and should save to different paths.

Though we can separate out some utilities functions like openJson(filename) although I believe the library jsonfile already has that.