search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Cloning repos is broken #134

Closed henryli333 closed 5 years ago

henryli333 commented 5 years ago

Currently, all attempts to clone online repositories are returning 401 error codes. This is due to the current function for cloning not being updated to work with the new method of authentication (the old function is looking for credentials from router.ts; credentials have now been refactored to be stored in storeCredentials.ts instead, but the clone function in authenticate.ts hasn't been updated or moved into a new component yet).

henryli333 commented 5 years ago

Related to issue #129

qw commented 5 years ago

Credential storage are handled by crendential-store.service.ts not storeCredentials.ts. storeCredentials.ts is deprecated and will be removed soon (it was removed although some PR that did not correctly synchronise with master brought it back).

qhen143 commented 5 years ago

Screenshot (45) Cannot reproduce as of PR #127. Got to deal with modal error first, likely due to removal of bootstrap from #127 .

r4inee commented 5 years ago

Screenshot (45) Cannot reproduce as of PR #127. Got to deal with modal error first, likely due to removal of bootstrap from #127 .

Yeah Jest doesn't like import "bootstrap", currently finding a fix (hopefully)

r4inee commented 5 years ago

See #140.