kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

[#6] Fix issue 6 and partial refactor git.ts into file.service.ts and file.panel.component.ts #137

Closed YichenTang97 closed 5 years ago

YichenTang97 commented 5 years ago

Fixes #6, fixes #27, fixes #28, fixes #31, and a partial process of #81.

Manual test steps:

Test one:

  1. npm start
  2. either sign in or continue without sign in
  3. open a local repository
  4. in the local repository, create a new text file
  5. the new text file should show up no longer than 3 seconds in the file panel image
  6. without committing the change, delete the new file locally
  7. the file should disappear from the file panel no later than 3 seconds, and the "Your modified files will appear here" placeholder should reappear image

Test two:

  1. repeat step 1 to 4 in test one
  2. create another text file
  3. both new files should show up no longer than 3 seconds in the file panel image
  4. click one of them to open diff panel for the file image
  5. remove the corresponding file locally
  6. the corresponding file should disappear from file panel no later than after 3 seconds and the diff panel should be closed automatically image
YichenTang97 commented 5 years ago

Conflicts from #140. (import "bootstrap")

Fixed the conflictions in the new changes

r4inee commented 5 years ago

Also just a note, probably will be hard at this stage as the methods are quite big, but can add some tests with the service, maybe even as a separate PR considering the size.

YichenTang97 commented 5 years ago

Also just a note, probably will be hard at this stage as the methods are quite big, but can add some tests with the service, maybe even as a separate PR considering the size.

Will be adding the tests in next PR.

henryli333 commented 5 years ago

LGTM; will unblock once #142 is merged and this branch is tested on Windows :+1:

YichenTang97 commented 5 years ago

Rebasing this branch to the latest master after #157 and #152......

YichenTang97 commented 5 years ago

......Done

Tested against manual test steps in #157 and #152

Some changes are made from #157:

YichenTang97 commented 5 years ago

Merge conflicts fixed: adapted changes made in #162.