search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

"Color" button broken #139

Closed smor264 closed 5 years ago

smor264 commented 5 years ago

Possibly related to issue #4. Color drop down doesn't change the theme when you select a color. Style dropdown still works. ThemeIssue

Need to fix or potentially remove color button.

egodihc commented 5 years ago

Are you saying that it doesn't drop down, or that it doesn't change the color?

egodihc commented 5 years ago

Wait I can't reproduce the bug, they both work.

smor264 commented 5 years ago

For me, the drop down shows you the list of options but clicking them doesn't change the theme. This is on the commit "[135] Fixed cloning location inconsistencies"

egodihc commented 5 years ago

Just making sure, you have these lines of code representing the dropdown in authenticate.component.html? <ul class="dropdown-menu" id="color-dropdown" role="menu" aria-labelledby="branch-name"> <li class="white" (click)="themeService.setTheme('white')">white</li> <li class="pink" (click)="themeService.setTheme('pink')">pink</li> <li class="blue" (click)="themeService.setTheme('blue')">blue</li> <li class="navy" (click)="themeService.setTheme('navy')">navy</li> <li class="green" (click)="themeService.setTheme('green')">green</li> <li class="default" (click)="themeService.setTheme('default')">default</li> </ul>

smor264 commented 5 years ago

Yup, I have those lines

HenrygShen commented 5 years ago

Yea, I have the same issue as you.

Actually, slightly different. I don't even get a dropdown when I click color.

smor264 commented 5 years ago

I think that since the "style" tab works for everyone and is available everywhere in the app, the color button/drop-down is redundant and should be removed.