search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Downgrade nodegit to 0.13.2 #145

Closed r4inee closed 5 years ago

r4inee commented 5 years ago

Closes #144, Closes #138

Can windows users please pull and check as it seems like it is only affecting windows users.

  1. Remove node_modules, out, build, typings folder
  2. Make sure version of electron in .npmrc to 1.2.8.
  3. npm install
  4. npm run compile
  5. npm start and check if the application run without errors
  6. Close the app and run npm test to make sure test passes.
henryli333 commented 5 years ago

After building from your branch, tests still would not run, and same error from before persists. image.

Update: Note that the dependency's path begins with "\\?\". This means that it's likely that the path for dependencies aren't being pathed correctly (maybe because of imports vs requires?)

henryli333 commented 5 years ago

\\?\ has been determined to not be the issue; change request cancelled.

r4inee commented 5 years ago

Closes #138