search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

[#12]Cloning now has a progress bar #153

Closed wjsoft08 closed 5 years ago

wjsoft08 commented 5 years ago

This closes #12 When cloning now there is a progress bar when cloning.

To test whether this is working: 1. Fill in your clone URL and desired directory destination then click the Clone button. ProgressSetUp

2. You should be able to see the progress bar like the screenshot below ProgressBar

3. Finally, check whether the cloning was successful or not by check if the project exists at the directory you selected

rocketBANG commented 5 years ago

If you are going to change where the progress bar is, I would suggest putting the progress bar in a separate component and then having a % input into in so that it can be reused in multiple places

qw commented 5 years ago

If you are going to change where the progress bar is, I would suggest putting the progress bar in a separate component and then having a % input into in so that it can be reused in multiple places

I thought about this as well, but can you use an Angular component in a normal HTML file? Or at least call it ?

egodihc commented 5 years ago

If you are going to change where the progress bar is, I would suggest putting the progress bar in a separate component and then having a % input into in so that it can be reused in multiple places

I thought about this as well, but can you use an Angular component in a normal HTML file? Or at least call it ?

Yes

Excaleo commented 5 years ago

Since repo.ts has been refactored in #207, downloadFunc is no longer used in cloning a repository. Instead it is done in repository.service.ts using the downloadRepository function.

@wjsoft08 maybe you can review the function and make changes to the PR? You probably need a global function to update the progress only in repo.ts.

Also good work, I had a hard time navigating the nodegit docs so I'm sure you had a hard time finding this property.

wjsoft08 commented 5 years ago

Since repo.ts has been refactored in #207, downloadFunc is no longer used in cloning a repository. Instead it is done in repository.service.ts using the downloadRepository function.

@wjsoft08 maybe you can review the function and make changes to the PR? You probably need a global function to update the progress only in repo.ts.

Also good work, I had a hard time navigating the nodegit docs so I'm sure you had a hard time finding this property.

I have made the change into your new change now @Excale0