kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

[48] Add text editor to VisualGit #157

Closed rocketBANG closed 5 years ago

rocketBANG commented 5 years ago

Closes #48 Includes some style fixes for the diff panel Screenshot_20190405_182800 Moves the save and cancel buttons to the edit panel Screenshot_20190405_182820

Includes a very basic text editing that is accessible from clicking on the "edit" button when viewing the diff of a file Can either save the edited text, or cancel and return to the diff

Test

Setup

Open a repository with 1 or more changes Go to main view (in screenshots)

Test 1 Diff panel opens first

Test 2 Edit cancels

Test 3 Edit saves

rocketBANG commented 5 years ago

Nice work.

Can you change the green to one that's easier to look at? Maybe use GitHub's green background (#e6ffed) and black text?

I'm not going to fix the colours - that can be done in a separate PR