kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Navbar push button doesn't work #165

Closed antdangnz closed 5 years ago

antdangnz commented 5 years ago

When you use the push button in the navbar, it opens up a modal but does not seem to actually push any of the changes that were made.

Steps to reproduce:

  1. Log into VisualGit
  2. Open up a local repository
  3. Make some changes to the repository. Either add or edit some files.
  4. Add and commit the new/changed files
  5. Use the push button in the navbar.

With further investigation, if you open up the repository on any other Git GUI or through the command line, you will see that the local repository is still ahead by one commit (assuming the repo was originally up to date with whatever branch it is in).

The console shows that VisualGit was able to print out "Pushing changes to remote", but does not provide any details whether it was successful or not: 7cYc4l0dfZ NOTE: On Mac it also crashes and white screens.

Originally thought that this issue was related to #55 but I haven't experienced any crashing yet, and I made sure to commit my changes before using the button.

Potential solution: file: git.ts, function: pushToRemote, credentials passed in from RouterCredentials isn't valid. Maybe try to retrieve a decrypted temp password from user.service and pass it into this => Nodegit.Cred.userpassPlaintextNew(username, password);

hybrio commented 5 years ago

waiting on https://github.com/kblincoe/VisualGit_SE701_2019_4/pull/237