kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Add Github Avatar/Image #175

Closed Menake closed 5 years ago

Menake commented 5 years ago

It would be nice to have the GitHub Avatar/Image show as well as the name

image

Maybe let someone from the graphing team take this up because we don't have a lot of tasks to do atm

antdangnz commented 5 years ago

Related to #52

Edit: The line is blurred between the Graph team and Github Integration team for these task. We'll probably write up some methods to retrieve the profile pic and let you guys deal with the rendering from there.

Menake commented 5 years ago

Related to #52

Yeah they're similar I think maybe they could be done in conjunction but #52 is related to the graphing which I think we may be changing because the framework/api they are currently using for graphing (vis.js) doesn't seem too flexible to customization.

I think because of that it might be better to do these as separate items

Menake commented 5 years ago

Related to #52

Edit: The line is blurred between the Graph team and Github Integration team for these task. We'll probably write up some methods to retrieve the profile pic and let you guys deal with the rendering from there.

Sounds good

qw commented 5 years ago

This would be be a functional addition to user service for anyone taking on this issue.

egodihc commented 5 years ago

Related to #52

Edit: The line is blurred between the Graph team and Github Integration team for these task. We'll probably write up some methods to retrieve the profile pic and let you guys deal with the rendering from there.

In case anyone is wondering, GitHub already has an API for retrieving user information :
https://api.github.com/users/:username

antdangnz commented 5 years ago

In case anyone is wondering, GitHub already has an API for retrieving user information : https://api.github.com/users/:username

VisualGit is currently using octonode (v0.7.2 iirc) at the moment to communicate with Github (using the Github v3 APIs). Haven't gotten far into playing around with it yet but I'm guessing there will be some method that uses the API you referenced. Hopefully 😅