search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Sign in button not replaced by username quickly enough #190

Open henryli333 opened 5 years ago

henryli333 commented 5 years ago

The sign in button does not refresh quickly enough on the GUI, and there exists a small bug where you can be taken back to the login page for a short duration. See gif below: signout

Steps to reproduce:

  1. Login through any method
  2. As soon as the screen changes, click on the top right button before the username is displayed

Actual behaviour: You are taken back to the login screen for a brief moment before being taken to the user screen

Expected behaviour: You should not be taken back to the login screen at all

r4inee commented 5 years ago

See discussions in #168. Likely related and can be combined as one issue.

Excaleo commented 5 years ago

Probably related to how logIn function in AuthenticateComponent.ts calls an asynchronous function but loginWithSaved calls it directly without waiting for anything.

Edit: nvm it seems that signin has this issue too.