search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Can't close application under certain conditions #208

Closed HenrygShen closed 5 years ago

HenrygShen commented 5 years ago

Steps to reproduce: 1: Sign in 2: Open a repository with uncommitted content 3: Wait for the file-panel to load the changed files 4: Sign out 5: Try to close the application

At this point, the 'X' button on the top right should be unresponsive and the app will not close even using alt-f4. The app still seems to work as usual, and if you sign in again, you will be able to exit the app normally.

Tested on Windows 10.

antdangnz commented 5 years ago

Any idea on how to fix this issue?

HenrygShen commented 5 years ago

Probably something to do with the "onbeforeunload" property for window events. In the file service, it changes the "onbeforeunload" property when there are modified files. When you have modified files and try to exit without committing and pushing, the app will prompt you to reload, exit, or go back. I think that prompt is supposed to appear on the login screen, but doesn't for whatever reason. Maybe we should prevent people from signing out if there are uncommited changes.