search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Changing graphing library #210

Open Menake opened 5 years ago

Menake commented 5 years ago

Currently, the graph uses vis.js which is is good for creating directed graphs with nodes and edges. I propose using a different library, an example I found was gitGraph.js which can be used to create nice Git graphs as seen below. image

I believe this is a large issue as the current graphing.ts and graphSetup.ts files are quite highly coupled. There is also limited documentation about gitGraph so it may take a while to add. I think this is a nice feature to add as it will also resolve #49 and #58.

r4inee commented 5 years ago

I like it!

Menake commented 5 years ago

Unfortunatley, this library can't handle branching very well when there are multiple branches. The main issue is that every new branch is created one column to the right even if an old branch was closed so the branch history looks as seen below.

ezgif com-video-to-gif (1)

@gnawf spent a lot of his time helping me trying to fix this issue (which I think is about very-large in terms of time/effort spent) and although I don't think this can be introduced into the repository, I'd like to see what other's think.

@sloushsu, @hybrio, @rocketBANG, @shurui-li

YichenTang97 commented 5 years ago

Sad to hear that but your works on this issue are much appreciated. It may not eventually be added to the repo but your efforts on it are definitely worth to be there, thank you for the hard work. I will change the label to very large because apparently a big amount of effort has been put into the issue and for solving the problem with that library.