search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

[164] Add popups to replace informational modals #214

Closed rocketBANG closed 5 years ago

rocketBANG commented 5 years ago

Adds a popup service that can be used to show auto-dismissing popups instead of the current modals fixes #164

The popups will animate in and then animate out after a set duration. Multiple popups can be chained and will be shown in order

Screenshot_20190409_223509

antdangnz commented 5 years ago

Small bug/oversight. When I try to open up an invalid folder as a local repo, it displays the popup service as intended. The problem is: when I repeatedly press the button multiple times afterwards, the popup keeps appearing over and over (as many times as I pressed the button).

Steps to reproduce:

  1. Log in
  2. Open a local repository 2.1. Choose a folder that isn't a repo
  3. Spam the 'Open' button
  4. Watch as the popup keeps appearing and tell you that the repo could not be found
rocketBANG commented 5 years ago

Small bug/oversight. When I try to open up an invalid folder as a local repo, it displays the popup service as intended. The problem is: when I repeatedly press the button multiple times afterwards, the popup keeps appearing over and over (as many times as I pressed the button).

Steps to reproduce:

  1. Log in
  2. Open a local repository 2.1. Choose a folder that isn't a repo
  3. Spam the 'Open' button
  4. Watch as the popup keeps appearing and tell you that the repo could not be found

This is currently the intended behaviour. What would be your expected behaviour?

antdangnz commented 5 years ago

Small bug/oversight. When I try to open up an invalid folder as a local repo, it displays the popup service as intended. The problem is: when I repeatedly press the button multiple times afterwards, the popup keeps appearing over and over (as many times as I pressed the button). Steps to reproduce:

  1. Log in
  2. Open a local repository 2.1. Choose a folder that isn't a repo
  3. Spam the 'Open' button
  4. Watch as the popup keeps appearing and tell you that the repo could not be found

This is currently the intended behaviour. What would be your expected behaviour?

Would be nice to only have one popup show, even if the button was spammed. No point showing the same error multiple times if nothing has changed. Could replay the popup if the button is pressed again after the previous popup is finished.

rocketBANG commented 5 years ago

Okay, I have limited it so that popups with the exact same text cannot be spammed -> there can only be a max of 2 (one currently showing and one queued)