search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

[#212] Abstract node naming issue fixed #217

Closed dlrrb4714 closed 5 years ago

dlrrb4714 commented 5 years ago

Fixes issue #212. Now the author name is correctly shown accordingly. Also tidied up some of the code in graphing.ts to shorten the code and improve readability.

image

image

To test

  1. Compile the app with npm run compile
  2. Run the app with npm start
  3. Log in and open a repo
  4. Hover over commits to see information about each commit
  5. Zoom into commits and repeat Step 2 to find author's name correctly stated in each commit along
  6. with number of commits and commit message.
antdangnz commented 5 years ago

Interesting bug I found while examining the graph. Some of the nodes would show the full name of the author, and some would show their GitHub username instead. Not sure if it's an issue with this PR but it's interesting to note. See below:

Can confirm Reuben is rocketBANG 💯 electron_1CqOc2buel

electron_xo5b5poqtn

Rohan === rdso323

electron_SKODjnCrFH

electron_TAf2mc7K6n

rocketBANG commented 5 years ago

@antdangnz I think that's probably when some commits are made using GitHub vs locally. My name is set to my full name locally but on GitHub it reverts to username

Can confirm Reuben is rocketBANG 💯

Why've you gotta expose me like that :angry:

hybrio commented 5 years ago

Interesting bug I found while examining the graph. Some of the nodes would show the full name of the author, and some would show their GitHub username instead. Not sure if it's an issue with this PR but it's interesting to note.

does this mean #11 is still an issue?