search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Sign in button spam breaks error messages and triggers github rate limiting #218

Closed hybrio closed 5 years ago

hybrio commented 5 years ago

The sign in button when spammed will cause the screen to remain dark (when the error goes away) and will trigger the github api's rate limiting as each press is a sign in call.

Steps to Reproduce: 1 open app 2 spam click sign in button until the app breaks

hybrio commented 5 years ago

The simple solution for the rate limiting is to disable the sign in button after it's been pressed until the login resolves or errors. The error modals issue might not be a thing anymore after #164

egodihc commented 5 years ago

Closely related to #201 where the solution is disabling the button until the auth request returns.