Added visual feedback for selected file in file panel

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Added visual feedback for selected file in file panel #220

Closed egodihc closed 5 years ago

egodihc commented 5 years ago

Closes #202 When you click on a file to view in the diff panel, the color changes for that file in the file panel. This gives visual feedback on which file is being viewed.

Also added a missing closing brace for the .popup-error class in styles.css

dlrrb4714 commented 5 years ago

Agree with the previous comment. Feature wise, LGTM!

I tried a darker colour for the background, maybe this colour is better? Tbh there's no perfect colour for this cause the font colours for different themes range from white to black, if anything we need to change the font colours for different themes

HenrygShen commented 5 years ago

Yup LGTM. You could try a blueviolet color. It works pretty well with each theme color.

qhen143 commented 5 years ago

@lincolnChoy Could you add HelpScreenComponent to 'declarations' in 'app.modules.ts' as part of the fix for #223 . This will resolve this console error: