search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Help screen no longer has css applied. #223

Closed qhen143 closed 5 years ago

qhen143 commented 5 years ago

After a while of backtracking, #214 was merged in before fetching changes from previous PRs.

Steps to reproduce:

  1. Checkout e14d21751b31ac2d1d7132472ead30a90c240e9f or later.
  2. npm run compile
  3. npm start
  4. In the menu, under help, click 'VisualGit: a visually oriented etc'

Observed results: Help screen has css applied. Actual result: Help screen doesn't have the css applied.

egodihc commented 5 years ago

I fixed this in #220, there was a missing closing brace which broke the .help-screen class. Also, why the meme label?

qhen143 commented 5 years ago

Yup thanks, just noticed that was causing the issue. Didn't even notice the tag. I'll remove.