search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Migrate/refactor diff panel UI logic from file service to diff panel component #230

Closed WanniCode closed 5 years ago

WanniCode commented 5 years ago

Currently, file.service.ts handles the UI logic/updates of the diff panel: for example, displaying the line number git diff when selecting a file from the file panel. Instead, this logic should be handled by the diff panel component (diff.panel.component.ts), which is more idiomatic Angular.

This will also help create a cleaner and more consistent linking between the diff service (currently being written, see #149) and the rest of the application, in particular the diff panel UI component.

WanniCode commented 5 years ago

seems to be duplicate of #195 @NotWowe can you confirm if you're migrating the diff panel UI logic into the diff panel component? How is the file service's on click handler for a selected file being linked to the diff panel?

WanniCode commented 5 years ago

closed for now - after some discussion, we figured it might be best to pair on #195 since it encapsulates this issue

henryli333 commented 5 years ago

This refactor is best done independently of #195

WanniCode commented 5 years ago

This refactor is best done independently of #195

merged as separate PR now

bowenzheng98 commented 5 years ago

Added approved label as it was mistakenly not added before

WanniCode commented 5 years ago

updated size to Large since the refactor was larger than expected - in particular, a methodology for directly connecting components (file.panel.component.ts and diff.panel.component.ts) had to be added as a separate service, leading to more additions than anticipated.