kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

File service refactor breaks header.component.ts #242

Closed bowenzheng98 closed 5 years ago

bowenzheng98 commented 5 years ago

A method that was removed in the refactor for file.service.ts is still being used in header.component if(this.fileService.areFilesModified()) . This can be fixed by change the method being invoked to getModifiedFilesPromise() and check if the list is not empty.

HenrygShen commented 5 years ago

238 fixed the issue #208 which I tried to fix in #235.

You could probably just remove the code I added in #235 to fix this issue

bowenzheng98 commented 5 years ago

@HenrygShen the solution I proposed didn't work would you mind adding the method back in?

bowenzheng98 commented 5 years ago

Closing this issue after discussing with @HenrygShen as it seems like this is no longer intended functionality