search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Remotes drop down functionalities still work when there are no active repositories. #258

Closed qhen143 closed 5 years ago

qhen143 commented 5 years ago

Remotes should not show the remote drop down functionality when there is no active repository.

Steps to reproduce:

  1. Reload the application.
  2. Navigate to add repository page.
  3. Click the remote drop down.
  4. Add a remote using the drop down. Observed results: Clicking the remote drop down throws errors when no repository is active. Adding a remote functionality still available when no repository is active.

Possible fixes:

HenrygShen commented 5 years ago
  1. Return to add repository page.
  2. Add a remote using the drop down. Observed results: Remote of last active repository are visible and a new remote is added.

I don't think this part is a problem, because you can still go back to view the files with the back arrow, so you're still in the current active repository. image

But it's probably a good idea to disable/hide the drop down when there is no active repository.

qhen143 commented 5 years ago

Oh right, I thought there was no way to return after 'branch' got fixed. I will update the issue.