search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Added GitHub profile next to username in header #263

Closed manacarr98 closed 5 years ago

manacarr98 commented 5 years ago

Addresses issue #175

Can be tested by signing in. GitHub profile should appear next to the username of the current user (given that they have signed in), otherwise does not display an image.

Screenshot (24) Screenshot (23)

antdangnz commented 5 years ago

Just an idea, do we want to remove the username button altogether and just give its click functionality to the image? Just like how it looks on GitHub (See below... or above).

image

rocketBANG commented 5 years ago

Just an idea, do we want to remove the username button altogether and just give its click functionality to the image? Just like how it looks on GitHub (See below... or above).

I think this is more consistent for the UI. Otherwise we'll also have to implement a dropdown as the current click action takes the user to a new screen

KaranramanathanUoA commented 5 years ago

Can we merge this PR as I think the work is done?