search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Side difference #277

Closed bowenzheng98 closed 5 years ago

bowenzheng98 commented 5 years ago

Resolves #151

The scope of this feature has been changed after discussion with @NotWowe and @WanniCode

The feature now shows the file from the HEAD commit on the side of the current file when in edit mode.

Note: Currently the graph is being hidden using .getElementedById() as there is no service setup to do this

Reopening as this was accidentally closed by @Menake

henryli333 commented 5 years ago

I think I found the problem; there's a -15px padding on the element (See screenshot) image

I'm unfamiliar with the styling so I'm not sure how to fix this myself.

bowenzheng98 commented 5 years ago

Made changes suggested by @NotWowe as I am unable to see these issues from my end

henryli333 commented 5 years ago

Resolves previous issue, but I just found a new issue with feature. Scrolling only follows the right panel's, meaning if the right panel is shorter than the left, you cannot see the entire file on the left. See screenshot below. image

henryli333 commented 5 years ago

Latest change fixed scrolling to end issue: image