search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

[#233] Improves the error messages in sign-in #279

Closed bpat714 closed 5 years ago

bpat714 commented 5 years ago

Resolved #233

Previously the error messages weren't as informative. They have been improved to correctly address the problem during sign in.

Steps to test: 1) Run application (npm start) 2) Attempt to sign in with no internet. "The sign-in failed because the service is not avaliable or you may not be connected to the internet" -- this message should popup on the screen. 3) Sign in with incorrect details. "The username or password you have supplied is incorrect" -- this message should popup on the screen.

signin

dlrrb4714 commented 5 years ago

LGTM! Messages look good.

wjsoft08 commented 5 years ago

LGTM now since you have fixed @Menake's request.