search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Back button when no repository is opened brings up graph #288

Open dlrrb4714 opened 5 years ago

dlrrb4714 commented 5 years ago

Observed Behaviour When the back button in the repository is pressed without opening a repository, the program opens up the graph display page.

Preferred Behaviour If a repository has not been previously opened, maybe an error message can be thrown to acknowledge the user that a previous page doesn't exist.

image

image

Steps to reproduce

  1. Compile the program with npm run compile
  2. Run with npm start
  3. Log in with Github credentials
  4. Press back button on top left without opening a repository
dylanfu commented 5 years ago

Yea, you could probably check if currentRepo is equal to null, from repository.service using the getCurrentRepo() function to determine whether to route or not, then throw a popup