search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Use Angular features #81

Closed Menake closed 5 years ago

Menake commented 5 years ago

The code base doesn't really make use of angular. E.g. DOM elements are referenced using "document.getElementById" which basically makes angular redundant. This also throws a lot of errors in our linting as there's no type checking for that. A better practice would be to use Angular's @ViewChild and tag the DOM elements with a specfic tag. This is one example, It would be nice to check for more issues and fix them as well. I think better to do this to reduce our technical debt now before we start making huge changes

r4inee commented 5 years ago

This might be a large task considering how many document.getElementById calls there are in the code base. It's also gonna have conflicts with almost everyone.

qw commented 5 years ago

This might be a large task considering how many document.getElementById calls there are in the code base. It's also gonna have conflicts with almost everyone.

Alternatively this can be resolved as we go. As we see things like getElementById() in functions we work on, we replace them with Angular features.

Although this can't be really enforced and can't be related to a single issue.

r4inee commented 5 years ago

Closing this as discuss in team meeting. Split this into other issues as they refactor the codebase.