search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Messy routing system/Angular routing is not used #88

Closed qw closed 5 years ago

qw commented 5 years ago

A partial breakdown of #81.

There is currently no structure in routing between pages/screens, flow between different components and screens are control by components everywhere.

We should use Angular's routing feature.

egodihc commented 5 years ago

Probably will need to wait for issue #83 to be resolved before fixing this due to the way that Angular routing works.

egodihc commented 5 years ago

Turns out implementing this is much more complex than I originally thought. There is the huge issue of direct DOM manipulation everywhere in the application. The effects of this are accentuated through the fact that in the original code, without proper routing, all the HTML elements are already created. This causes issues such as #116 , and makes routing more dependent on resolution of issues such as #89 .