Login does not support two factor authentication (2FA)

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Login does not support two factor authentication (2FA) #91

Closed henryli333 closed 5 years ago

henryli333 commented 5 years ago

For users who use GitHub 2FA for logins, the following error is shown upon trying to login: 2fa

Support could be added to allow such users to login to the app.

r4inee commented 5 years ago

Currently rewriting authentication into separate service and @hybrio is working on the login screen so temporarily blocked. Sorry for blocking 😃

hybrio commented 5 years ago

getting close to completion on this one, however it requires some routing changes for me to input the 2FA codes. could someone run me through how to either create a modal or a modified version of the sign in page to get the 2FA code off the user?

hybrio commented 5 years ago

follow up, due to a validation issue with the two factor functionality in octonode i am going to have to drop this feature. essentially the initial two factor sms would send but the entered code would never validate. this issue was reported a few years back but never resolved: https://github.com/pksunkara/octonode/issues/280