search

kblincoe / VisualGit_SE701_2019_4

1 stars 0 forks source link

Casing inconsistency on sign-in panel #95

Closed Excaleo closed 5 years ago

Excaleo commented 5 years ago

The placeholder for Username and Email is capitalized while the password placeholder isn't.

image

They should probably be consistent.

r4inee commented 5 years ago

This is part of the sign-in pack of issues, refer to #86.

Excaleo commented 5 years ago

86 is targeted towards functionality and design of the authentication functions and variables, this is a front end change that would reflect in authenticate.component.ts

r4inee commented 5 years ago

Yes, however refactoring the design in authenticate.ts would also result in different methods being called by the components + additional dependencies injected into authenticate.component.ts.

Similar to how this issue #61 is related to #86 and I should've mentioned its currently blocked.