search

kblincoe / VisualGit_SE701_3

0 stars 0 forks source link

The nodegit commit class does not store username, it only stores full name and email. #122

Open shoebilldev opened 6 years ago

shoebilldev commented 6 years ago

The nodegit commit class does not store username. It would be good to have a way to find the username of the committer, instead of just the email or full name.

Below is the documentation for nodegit's author and committer api and the information they hold about committers.

http://www.nodegit.org/api/commit/#author http://www.nodegit.org/api/commit/#committer

You could search github's API for the full name or email but people share full names, not everyone has emails public and not everyone only has one account with each email.

This issue blocks #27

@softeng-701

softeng-701 commented 6 years ago

@tagumi Approved, does this additional issue mean you are happy with the size of #27 ?

shoebilldev commented 6 years ago

@softeng-701 yes, with the approval of this issue I think the size of #27 as medium is appropriate